Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling modal animations #502

Merged
merged 1 commit into from
May 12, 2020
Merged

Allow disabling modal animations #502

merged 1 commit into from
May 12, 2020

Conversation

jacobp100
Copy link
Contributor

@jacobp100 jacobp100 commented May 8, 2020 •
edited
Loading

Allows disabling modal animations via stackAnimation: 'none' on iOS. Android already handles this

Fixes #494

@WoLewicki
Copy link
Member

Looks good. Did you test it to check if the completion handler always fires despite no animation?

@jacobp100
Copy link
Contributor Author

Just tried it now - it does still fire!

@WoLewicki
Copy link
Member

Great! I am merging it then.

@WoLewicki WoLewicki merged commit 5201478 into software-mansion:master May 12, 2020
@jacobp100
Copy link
Contributor Author

Thanks!

@WoLewicki WoLewicki mentioned this pull request May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow changing animation for modals
2 participants
@jacobp100 @WoLewicki