New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set final frame of fade animation #527

Merged

WoLewicki merged 1 commit into master from @wolewcki/fade-animation

Jul 21, 2020

Member

WoLewicki commented May 28, 2020

According to https://developer.apple.com/library/archive/featuredarticles/ViewControllerPGforiPhoneOS/CustomizingtheTransitionAnimations.html, the final frame of the toViewController's view should be set via finalFrameForViewController: method. It fixes the problem with the view, which we transition to, not respecting the header's height. Should resolve #326.


          fix: set final frame of fade animation

f0c41ab

WoLewicki mentioned this pull request

stackAnimation set to fade or none ignores navigation bar #326

Closed

WoLewicki merged commit 12a0870 into master

WoLewicki deleted the @wolewcki/fade-animation branch

July 21, 2020 08:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet