Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rework open/back animation logic on Android #871

Merged

Conversation

kacperkapusciak
Copy link
Member

@kacperkapusciak kacperkapusciak commented Mar 31, 2021

Description

Intricate logic for animation opening and closing screens in Android introduced incontinency in navigation.reset.
The issue is described in detail in #865.
Fixes #865.

Changes

  • (Hopefully) simplified transition logic in Android.

Screenshots / GIFs

Before

reset.before.mov

After

reset.after.mov

Test code and steps to reproduce

Provided Test865.tsx in TestsExample project.

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

Copy link

@tomtargosz tomtargosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that #865 is fixed with this!

Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please answer to the comments.

Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment on the suggestions. After this, I think it is ready to be merged.

TestsExample/src/Test865.tsx Outdated Show resolved Hide resolved
@kacperkapusciak kacperkapusciak merged commit 81e58b2 into master Apr 2, 2021
@kacperkapusciak kacperkapusciak deleted the @kacperkapusciak/slide-from-right-reset-issue branch April 2, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants