Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search field color #961

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Conversation

WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented May 31, 2021

Description

Added option to set color of text in iOS search bar.

Changes

Added new prop to SearchBar.m and types.
Added checks for availability of iOS 13 in proper places.

Test code and steps to reproduce

Test758.tsx in TestsExample app.

Checklist

@WoLewicki WoLewicki mentioned this pull request May 31, 2021
9 tasks
@WoLewicki WoLewicki merged commit 4938fc5 into master Jun 1, 2021
@WoLewicki WoLewicki deleted the @wolewicki/search-bar-text-color branch June 1, 2021 09:34
@nandorojo
Copy link

nandorojo commented Jun 26, 2021

Hey @WoLewicki, I had some brief feedback about the search bar. It's working really well for me. Adds a total native feel to the app. I just had two points of feedback that I think could help it a lot.

  1. Hide the title

Screen Shot 2021-06-26 at 12 35 11 AM

I'd expect this code to hide the title above the search bar, bringing the search bar up to the top. However, it produces this result:

IMG_A6CB616A6079-1

Maybe an alternate API could be:

hideNavigationBar: "always" | "while typing" | "never"
  1. keyboardAppearance

My app is dark mode, so I'd love to be able to add keyboardAppearance="dark" to the keyboard.

Thank you so much for this awesome feature!

@WoLewicki
Copy link
Member Author

We are always open for PRs with new functionalities 🎉 I am not sure why changing the title to empty string would collapse the title part of the header, and for the hideNavigationBar, cannot it be done in code in the events like onFocus and onBlur of the searchBar?

@nandorojo
Copy link

nandorojo commented Jun 29, 2021

Yeah on second thought, an empty title shouldn't collapse the nav bar. I suppose I just wanted a way to have the nav bar always hidden. But I worked around it and added content to the header, so no worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants