Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning Calling bridge.imageLoader is deprecated #1136

Closed
wants to merge 2 commits into from

Conversation

r0b0t3d
Copy link

@r0b0t3d r0b0t3d commented Oct 4, 2019

Summary

Hi, I am using RN 0.61 and got this warning when using Image element on iOS.
The root cause is self.bridge.imageLoader has been deprecated

https://github.com/facebook/react-native/blob/0.61-stable/React/CoreModules/RCTImageLoader.h

Simulator Screen Shot - iPhone 8 - 2019-10-04 at 18 40 13

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a simulator
  • I have tested this on a device
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@msand
Copy link
Collaborator

msand commented Oct 19, 2019

@r0b0t3d Thanks for this! Have you tried this patch with any older versions of react-native? I think we might need to change the minimum supported version to merge this, and probably needs a major version bump.

There's actually a breaking change in the develop branch already, so this probably makes sense to release at the same time.

@msand
Copy link
Collaborator

msand commented Oct 19, 2019

Some of the new features in the develop branch are experimental/incomplete/broken still, but I think as long as I label them as such, I might be able to cut a release soon anyway. Would be great to get some examples/test case showing how they're broken to be able to fix them at this point, or create some synthetic but representative test scenarios. But haven't had any time to put into this lately.

@msand
Copy link
Collaborator

msand commented Oct 19, 2019

This is fixed in a slightly different way in the master branch / latest version. Closing. Thanks for you pr anyway!

@msand msand closed this Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants