Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FeGaussianBlur filter #2352

Merged
merged 14 commits into from
Jul 25, 2024
Merged

feat: add FeGaussianBlur filter #2352

merged 14 commits into from
Jul 25, 2024

Conversation

jakex7
Copy link
Member

@jakex7 jakex7 commented Jul 17, 2024

Summary

Continuation of #2316
Introducing new filter FeGaussianBlur.

Implementation notes

On Android there is no easy way to fully implement Gaussian blur, as there is no native api for this. While a basic implementation is possible with RenderScript, it does not allow for blur in one axis and greater than 25

Test Plan

Example app -> Filters -> FeGaussianBlur

Compatibility

OS Implemented
iOS
Android

@jakex7 jakex7 requested a review from WoLewicki July 22, 2024 09:36
@jakex7 jakex7 mentioned this pull request Jul 23, 2024
13 tasks
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Please answer them!

apple/Filters/RNSVGFeGaussianBlur.mm Show resolved Hide resolved
src/filter-image/FilterImage.tsx Outdated Show resolved Hide resolved
src/lib/extract/extractFilter.ts Outdated Show resolved Hide resolved
src/lib/extract/extractFilter.ts Outdated Show resolved Hide resolved
src/lib/extract/extractFilter.ts Outdated Show resolved Hide resolved
src/lib/extract/extractFilter.ts Outdated Show resolved Hide resolved
@jakex7 jakex7 merged commit 44254df into main Jul 25, 2024
8 of 9 checks passed
@jakex7 jakex7 deleted the @jakex7/filtersGaussianBlur branch July 25, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants