feat: add FeOffset filter
#2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
approved these changes
Jul 24, 2024
| if (props.in) { | ||
| extracted.in1 = props.in; | ||
| } | ||
| if (props.dx) { |
There was a problem hiding this comment.
Why do we have to handle the props that do not change at all this way? Can't we just use them directly in the component like here:
react-native-svg/src/elements/Rect.tsx
Line 36 in 67620f5
|
Also, should we add this filter to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #2316
Introducing new filter
FeOffset.Test Plan
Example app -> Filters -> FeOffset
Compatibility
Checklist
README.md