Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: circular-dependencies #2381

Merged
merged 11 commits into from
Jul 31, 2024
Merged

fix: circular-dependencies #2381

merged 11 commits into from
Jul 31, 2024

Conversation

bohdanprog
Copy link
Member

@bohdanprog bohdanprog commented Jul 30, 2024 •
edited
Loading

Summary

  • Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.
  • extract SVG web components.
  • extract web types.
  • extract utils function.

Test Plan

You can test that problem by running a test example Test1813

What are the steps to reproduce (after prerequisites)?

Without those changes, you can occur that problem by running a test example Test1813

Compatibility

OS Implemented
iOS ✅
Android ✅

@bohdanprog
fix: Require cycles are allowed, but can result in uninitialized valu…
92e821a 
…es. Consider refactoring to remove the need for a cycle.
@bohdanprog bohdanprog marked this pull request as ready for review July 30, 2024 11:56
@bohdanprog bohdanprog requested a review from jakex7 July 30, 2024 11:56
@bohdanprog bohdanprog self-assigned this Jul 30, 2024
jakex7
jakex7 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@jakex7 jakex7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakex7 jakex7 merged commit a27e17f into main Jul 31, 2024
1 check passed
@jakex7 jakex7 deleted the @bohdanprog/fix-circular-dependencies branch July 31, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakex7 jakex7 jakex7 approved these changes

Assignees

@bohdanprog bohdanprog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bohdanprog @jakex7