New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce hitSlop prop #2407

Merged

jakex7 merged 5 commits into main from @jakex7/featHitSlop

Aug 19, 2024

Member

jakex7 commented Aug 13, 2024 •

edited

Loading

Summary

At the beginning, I want to highlight, and thanks for @GrinZero for original PR #2323 that was the boilerplate for these changes. From react-native@69 HitSlop signature has changed, and now it can be either Insets or number.

Test Plan

Manually in Test2407

Compatibility

OS	Implemented
iOS	✅
Android	✅

jakex7 added 5 commits

August 13, 2024 10:31


          feat: add hitslop to declaration files

ecbd60f


          feat: change hitslop on android to dynamic to allow single number

f39b761


          feat: implement hitSlop on Apple both arch

20fc8b2


          test: add hitslop example

34f5686


          Merge branch 'main' into @jakex7/featHitSlop

e500032

jakex7 merged commit ca1c35c into main

10 checks passed

jakex7 deleted the @jakex7/featHitSlop branch

August 19, 2024 07:11

jakex7 mentioned this pull request

fix(svg-view): the hitSlop value should use float in android like in ios #2323

Closed

4 tasks

jakex7 mentioned this pull request

[Bug] the hitSlop value should use float on android like on ios #2326

Closed

github-merge-queue bot referenced this pull request in valora-inc/wallet


          chore(deps): update dependency react-native-svg to ^15.7.1 (#6084)

31dac57

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-svg](https://redirect.github.com/react-native-community/react-native-svg)
| [`^15.5.0` ->
`^15.7.1`](https://renovatebot.com/diffs/npm/react-native-svg/15.5.0/15.7.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-svg/15.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-svg/15.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-svg/15.5.0/15.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-svg/15.5.0/15.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>react-native-community/react-native-svg
(react-native-svg)</summary>

###
[`v15.7.1`](https://redirect.github.com/software-mansion/react-native-svg/releases/tag/v15.7.1)

[Compare
Source](https://redirect.github.com/react-native-community/react-native-svg/compare/v15.7.0...v15.7.1)

Hotfix for v15.7.0

#### What's Changed

- fix: exclude e2e from types in release by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
#[https://github.com/software-mansion/react-native-svg/pull/2454](https://redirect.github.com/software-mansion/react-native-svg/pull/2454)

**Full Changelog**:
software-mansion/react-native-svg@v15.7.0...v15.7.1

###
[`v15.7.0`](https://redirect.github.com/software-mansion/react-native-svg/releases/tag/v15.7.0)

[Compare
Source](https://redirect.github.com/react-native-community/react-native-svg/compare/v15.6.0...v15.7.0)

A minor release introducing the implementation of filter regions along
with some bug fixes 🔧

#### What's Changed

- fix: android svg scale 0 by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2424](https://redirect.github.com/software-mansion/react-native-svg/pull/2424)
- feat: e2e snapshot tests by
[@&#8203;CDFN](https://redirect.github.com/CDFN) in
[https://github.com/software-mansion/react-native-svg/pull/2338](https://redirect.github.com/software-mansion/react-native-svg/pull/2338)
- feat: add load method by
[@&#8203;WoLewicki](https://redirect.github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2427](https://redirect.github.com/software-mansion/react-native-svg/pull/2427)
- fix: reset paint settings before drawing final bitmap by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2439](https://redirect.github.com/software-mansion/react-native-svg/pull/2439)
- fix: add deprecated SvgViewManager to not break 0.72 by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2435](https://redirect.github.com/software-mansion/react-native-svg/pull/2435)
- docs: introduce about webpack by
[@&#8203;bohdanprog](https://redirect.github.com/bohdanprog) in
[https://github.com/software-mansion/react-native-svg/pull/2434](https://redirect.github.com/software-mansion/react-native-svg/pull/2434)
- docs: broken link in the readme file by
[@&#8203;JohnAdib](https://redirect.github.com/JohnAdib) in
[https://github.com/software-mansion/react-native-svg/pull/2443](https://redirect.github.com/software-mansion/react-native-svg/pull/2443)
- feat: implement filter region by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2441](https://redirect.github.com/software-mansion/react-native-svg/pull/2441)
- fix: Android group `opacity` prop by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2417](https://redirect.github.com/software-mansion/react-native-svg/pull/2417)
- fix: render G offscreen only when it's needed (opacity != 1) by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2450](https://redirect.github.com/software-mansion/react-native-svg/pull/2450)
- fix: transform scale on android by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2452](https://redirect.github.com/software-mansion/react-native-svg/pull/2452)

#### New Contributors

- [@&#8203;JohnAdib](https://redirect.github.com/JohnAdib) made their
first contribution in
[https://github.com/software-mansion/react-native-svg/pull/2443](https://redirect.github.com/software-mansion/react-native-svg/pull/2443)

**Full Changelog**:
software-mansion/react-native-svg@v15.6.0...v15.7.0

###
[`v15.6.0`](https://redirect.github.com/software-mansion/react-native-svg/releases/tag/v15.6.0)

[Compare
Source](https://redirect.github.com/react-native-community/react-native-svg/compare/v15.5.0...v15.6.0)

In this version, we've introduced support for React Native 0.75, Fabric
support on Windows, and a few minor enhancements and fixes. Thank you to
everyone who contributed! 🚀

#### What's Changed

- chore: bump reanimated in macos example on paper by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2398](https://redirect.github.com/software-mansion/react-native-svg/pull/2398)
- feat: add support int32 color by
[@&#8203;bohdanprog](https://redirect.github.com/bohdanprog) in
[https://github.com/software-mansion/react-native-svg/pull/2397](https://redirect.github.com/software-mansion/react-native-svg/pull/2397)
- fix: implementation toDataURL for iOS platform both architectures by
[@&#8203;bohdanprog](https://redirect.github.com/bohdanprog) in
[https://github.com/software-mansion/react-native-svg/pull/2405](https://redirect.github.com/software-mansion/react-native-svg/pull/2405)
- chore: cleanup example apps by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2408](https://redirect.github.com/software-mansion/react-native-svg/pull/2408)
- feat(windows): add fabric support by
[@&#8203;marlenecota](https://redirect.github.com/marlenecota) in
[https://github.com/software-mansion/react-native-svg/pull/2321](https://redirect.github.com/software-mansion/react-native-svg/pull/2321)
- feat: support dataUri for android platform by
[@&#8203;bohdanprog](https://redirect.github.com/bohdanprog) in
[https://github.com/software-mansion/react-native-svg/pull/2396](https://redirect.github.com/software-mansion/react-native-svg/pull/2396)
- feat: introduce hitSlop prop by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2407](https://redirect.github.com/software-mansion/react-native-svg/pull/2407)
- feat: rewrite `Svg` transform by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2403](https://redirect.github.com/software-mansion/react-native-svg/pull/2403)
- Support-rgb(R%,G%,B%)-percentage by
[@&#8203;hryhoriiK97](https://redirect.github.com/hryhoriiK97) in
[https://github.com/software-mansion/react-native-svg/pull/2363](https://redirect.github.com/software-mansion/react-native-svg/pull/2363)
- chore: bump apps to RN 0.75 by
[@&#8203;WoLewicki](https://redirect.github.com/WoLewicki) in
[https://github.com/software-mansion/react-native-svg/pull/2340](https://redirect.github.com/software-mansion/react-native-svg/pull/2340)
- chore(deps): bump rexml from 3.2.6 to 3.3.3 in /tests-example by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/software-mansion/react-native-svg/pull/2410](https://redirect.github.com/software-mansion/react-native-svg/pull/2410)
- chore: fix prettier by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2416](https://redirect.github.com/software-mansion/react-native-svg/pull/2416)
- fix: do not resolve asset url for every object on web. by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2419](https://redirect.github.com/software-mansion/react-native-svg/pull/2419)
- fix: transforms on macOS old arch by
[@&#8203;jakex7](https://redirect.github.com/jakex7) in
[https://github.com/software-mansion/react-native-svg/pull/2420](https://redirect.github.com/software-mansion/react-native-svg/pull/2420)

#### New Contributors

- [@&#8203;hryhoriiK97](https://redirect.github.com/hryhoriiK97) made
their first contribution in
[https://github.com/software-mansion/react-native-svg/pull/2363](https://redirect.github.com/software-mansion/react-native-svg/pull/2363)

**Full Changelog**:
software-mansion/react-native-svg@v15.5.0...v15.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet