-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.0.0 #497
Merged
Merged
6.0.0 #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ale, skewX, skewY and matrix. Keep in mind that the current implementation doesn't support 3-arguments rotate(a, x, y) transform yet.
…t the Text/TSpan shapes, SVG coord tes case https://www.w3.org/TR/SVG/images/coords/OrigCoordSys.svg
Add conditional translation.preConcat(mMatrix) statement
Correct glyph point and delta x / y calculation and context handling. Remove incorrect whitespace from getLinePath method call. Correct the y coordinate of the text's origin when rendering glyphs into paths using getTextPath. Remove strange postTranslate transform. https://www.w3.org/TR/SVG11/text.html#TextOnAPath
Clear dx if x or dy if y is set in a GlyphContext. Make glyph preTranslate by dy instead of postTranslate. Scale glyph delta correctly.
Set paint flags for anti-alias, kerning for text, subpixel positioning of text. Add half of width of glyph to distance calculation for mBezierTransformer.getTransformAtDistance and preTranslate the glyph corresponding amount backwards (gives correct angles on glyphs when rendering text on a path) Add magical constant ratios of 1.2 into getBezierTransformer and getGlyphPointFromContext calls (should probably be based on some dpi ratio calculation)
…nt of if it is wrapped by a G element or not
Remove magic constants. Implement canvas.drawTextOnPath for reference comparison. Refactor PathShadowNode and BezierTransformer, expose getPath and getmStartOffset, implement inefficient but accurate enough getTotalDistance for debugging/diagnostics purposes.
‘kerning’ indicates whether the user agent should adjust inter-glyph spacing based on kerning tables that are included in the relevant font (i.e., enable auto-kerning) or instead disable auto-kerning and instead set inter-character spacing to a specific length (typically, zero). https://www.w3.org/TR/SVG/text.html#SpacingProperties https://www.w3.org/TR/SVG/text.html#KerningProperty
…Shift, startOffset. Add method and spacing attributes to textPath. Correct startOffset calculation. Implement method="stretch".
Implement support for fontSize value without unit identifier, processed as height value in the current user coordinate system. https://www.w3.org/TR/SVG11/text.html#FontSizeProperty
…etc. Fix parsing of transform to account for single parameter scale and translate correctly. Fix skewX, had opposite of intended effect. https://www.w3.org/TR/SVG/coords.html https://www.w3.org/TR/SVG2/coords.html https://www.w3.org/TR/SVGTiny12/coords.html https://www.w3.org/TR/SVG/coords.html#TransformAttribute https://www.w3.org/TR/SVG/coords.html#SkewXDefined
# Conflicts: # lib/extract/extractViewBox.js # package.json
This reverts commit 26bbc1c.
…idth correctly yet)
Implement hasGlyph ligature helper. Export view property setters for: text: textLength, baselineShift, lengthAdjust, alignmentBaseline, textPath: side, method, midLine, spacing. Attempt to fix alignmentBaseline and baselineShift, but both properties are nil at all times, I must be missing something.
@msand You can try to install this in 6.0.0-rc10 |
# Conflicts: # elements/TextPath.js # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@msand I had removed Quartz and PerformanceBezier from this repo.
Will run a postinstall script to download them from Github.
And finally this will be released as
6.0.0
.