Revert "Test compilation diagnostics reporter (#1577)"

This reverts commit 64c9eb6.
software-mansion · Sep 25, 2024 · ae57503 · ae57503
1 parent e256b69
commit ae57503
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/scarb/src/compiler/compilers/test.rs b/scarb/src/compiler/compilers/test.rs
@@ -37,17 +37,14 @@ impl Compiler for TestCompiler {
 
         let test_crate_ids = collect_main_crate_ids(&unit, db);
         // Search for all contracts in deps specified with `build-external-contracts`.
-        let all_crate_ids =
+        let main_crate_ids =
             get_contract_crate_ids(&build_external_contracts, test_crate_ids.clone(), db);
 
         let starknet = unit.cairo_plugins.iter().any(|plugin| {
             plugin.package.id.name == PackageName::STARKNET
                 && plugin.package.id.source_id == SourceId::for_std()
         });
 
-        let diagnostics_reporter =
-            build_compiler_config(db, &unit, &test_crate_ids, ws).diagnostics_reporter;
-
         let test_compilation = {
             let _ = trace_span!("compile_test").enter();
             let config = TestsCompilationConfig {
@@ -59,12 +56,13 @@ impl Compiler for TestCompiler {
                     .compiler_config
                     .unstable_add_statements_code_locations_debug_info,
             };
+            let allow_warnings = unit.compiler_config.allow_warnings;
             compile_test_prepared_db(
                 db,
                 config,
-                all_crate_ids.clone(),
+                main_crate_ids,
                 test_crate_ids.clone(),
-                diagnostics_reporter,
+                allow_warnings,
             )?
         };
 

diff --git a/scarb/tests/build.rs b/scarb/tests/build.rs
@@ -958,12 +958,6 @@ fn does_not_show_warnings_from_deps() {
         .current_dir(&second)
         .assert()
         .success();
-    Scarb::quick_snapbox()
-        .arg("build")
-        .arg("--test")
-        .current_dir(&second)
-        .assert()
-        .success();
 }
 
 #[test]