Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract scarb-ui crate and use it in all extensions #385

Closed
mkaput opened this issue May 31, 2023 · 0 comments · Fixed by #584
Closed

Extract scarb-ui crate and use it in all extensions #385

mkaput opened this issue May 31, 2023 · 0 comments · Fixed by #584
Assignees
@mkaput

Comments

@mkaput
Copy link
Member

mkaput commented May 31, 2023 •
edited
Loading

The cairo-test and runner plugins have a need to output some messages that ideally should follow Scarb's UI conventions, but they cannot re-use Scarb's UI machinery. This should be extracted to a always <1.0 crate.
@mkaput mkaput added this to Scarb May 31, 2023
@mkaput mkaput converted this from a draft issue May 31, 2023
@mkaput mkaput moved this from Triage to Backlog in Scarb Jun 5, 2023
@mkaput mkaput self-assigned this Jun 6, 2023
@mkaput mkaput moved this from Backlog to In Progress in Scarb Jun 6, 2023
@mkaput mkaput moved this from In Progress to Backlog in Scarb Jun 6, 2023
@mkaput mkaput moved this to Todo in Scarb Jul 3, 2023
@mkaput mkaput modified the milestone: Plugins Jul 11, 2023
@maciektr maciektr assigned maciektr and mkaput and unassigned mkaput and maciektr Aug 3, 2023
@maciektr maciektr moved this from Todo to Backlog in Scarb Aug 8, 2023
@mkaput mkaput moved this from Backlog to Todo in Scarb Aug 8, 2023
@mkaput mkaput moved this from Todo to In Progress in Scarb Aug 17, 2023
@mkaput mkaput mentioned this issue Aug 18, 2023
Merged
mkaput added a commit that referenced this issue Aug 18, 2023
@mkaput
Deprecate packages_filter feature in scarb-metadata
e5f0088 
fix #385

commit-id:389fc6bc
@mkaput mkaput linked a pull request Aug 18, 2023 that will close this issue
Deprecate packages_filter feature in scarb-metadata #584
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 22, 2023
@mkaput
Deprecate packages_filter feature in scarb-metadata
3c2fc95 
fix #385

commit-id:389fc6bc
@github-project-automation github-project-automation bot moved this from In Progress to Done in Scarb Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkaput mkaput

Labels
None yet
Projects
Scarb
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate packages_filter feature in scarb-metadata software-mansion/scarb
2 participants
@mkaput @maciektr