Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change compilation unit to enum #1155

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Change compilation unit to enum #1155

merged 1 commit into from
Feb 29, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Feb 19, 2024 •
edited
Loading

This was referenced Feb 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@maciektr maciektr requested a review from mkaput February 19, 2024 13:01
@maciektr maciektr marked this pull request as ready for review February 19, 2024 13:02
@maciektr maciektr mentioned this pull request Feb 19, 2024
Merged
@maciektr maciektr mentioned this pull request Feb 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 21, 2024
@maciektr
Implement procedural macro host generate_code for attribute macro (#…
336751b 
…1091)

Resolves #1127

commit-id:e59370d2

---

**Stack**:
- #1159
- #1157
- #1143
- #1151
- #1150
- #1148
- #1100
- #1155
- #1110
- #1093
- #1091 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr maciektr force-pushed the spr/main/bf749c51 branch 2 times, most recently from 3f081e2 to fd92c22 Compare February 21, 2024 14:12
@maciektr maciektr force-pushed the spr/main/aebc6424 branch 2 times, most recently from 0244f29 to 7494afe Compare February 21, 2024 15:29
github-merge-queue bot pushed a commit that referenced this pull request Feb 21, 2024
@maciektr
Implement loading shared libraries for proc macro plugins (#1093)
21e6d18 
Resolves #1128

commit-id:a3155bbf

---

**Stack**:
- #1159
- #1157
- #1143
- #1151
- #1150
- #1148
- #1100
- #1155
- #1110
- #1093 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
tomek0123456789
tomek0123456789 reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@tomek0123456789 tomek0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

scarb/src/compiler/compilation_unit.rs Show resolved Hide resolved
scarb/src/ops/metadata.rs Outdated Show resolved Hide resolved
scarb/src/ops/resolve.rs Outdated Show resolved Hide resolved
scarb/src/ops/resolve.rs Outdated Show resolved Hide resolved
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2024
@maciektr
Add test case for procedural macro compilation (#1100)
fcdae26 
commit-id:e457ae12

---

**Stack**:
- #1161
- #1159
- #1157
- #1143
- #1151
- #1150
- #1148
- #1155
- #1100 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/e457ae12 to main February 23, 2024 17:52
@maciektr maciektr changed the base branch from main to spr/main/1299f0be February 23, 2024 20:18
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2024
@maciektr
Implement check command for cairo plugins (#1148)
c4cde23 
commit-id:1299f0be

---

**Stack**:
- #1161
- #1159
- #1157
- #1143
- #1151
- #1150
- #1155
- #1148 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/1299f0be to main February 23, 2024 21:28
@maciektr maciektr changed the base branch from main to spr/main/fd15f5ab February 23, 2024 21:57
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2024
@maciektr
Run cargo fetch on workspace resolve (#1150)
e7bf5da 
commit-id:aeeb309e

---

**Stack**:
- #1161
- #1159
- #1157
- #1143
- #1155
- #1151
- #1150 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
github-merge-queue bot pushed a commit that referenced this pull request Feb 24, 2024
@maciektr
Use json output format in cargo if set in scarb_ui (#1151)
e220885 
commit-id:fd15f5ab

---

**Stack**:
- #1161
- #1159
- #1157
- #1143
- #1155
- #1151 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/fd15f5ab to main February 24, 2024 00:34
tomek0123456789
tomek0123456789 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@tomek0123456789 tomek0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maciektr maciektr force-pushed the spr/main/bf749c51 branch 2 times, most recently from c5a2c2d to f69b661 Compare February 27, 2024 11:45
@maciektr maciektr mentioned this pull request Feb 27, 2024
Closed
mkaput
mkaput approved these changes Feb 28, 2024
View reviewed changes
scarb/src/compiler/compilation_unit.rs Outdated Show resolved Hide resolved
@maciektr maciektr mentioned this pull request Feb 28, 2024
Merged
@maciektr maciektr enabled auto-merge February 29, 2024 13:06
@maciektr maciektr added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 4cbd85a Feb 29, 2024
42 checks passed
@maciektr maciektr deleted the spr/main/bf749c51 branch February 29, 2024 13:21
@BrewTestBot BrewTestBot mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomek0123456789 tomek0123456789 tomek0123456789 approved these changes

@mkaput mkaput mkaput approved these changes

@szymmis szymmis Awaiting requested review from szymmis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciektr @mkaput @tomek0123456789