Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propose consistent usage of debug from tracing #1324

Merged
merged 1 commit into from
May 29, 2024

Conversation

glihm
Copy link
Contributor

@glihm glihm commented May 27, 2024

Gm guys,

wondering if this is a typo or an actual fix.

In dojo we're using scarb as a dependency, and when we compile a package of the workspace this error occurs, which prevent us from building a specific package depending on scarb explicitly.

However, when the whole workspace is compiled, it works fine.

Inspecting the scarb code base, everywhere it seems to be tracing::trace, tracing::debug etc... Is this tracing::log::debug forgotten, but not a direct problem as it compiles fine anyway?

Thanks for the feedback!

@glihm glihm requested a review from maciektr as a code owner May 27, 2024 22:34
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Yes, this must be a typo! 🙇‍♂️ Thanks for pointing this out! 😍

In dojo we're using scarb as a dependency, and when we compile a package of the workspace this error occurs, which prevent us from building a specific package depending on scarb explicitly.

However, when the whole workspace is compiled, it works fine.

I do not see your error message, but the log module is behind a feature flag in tracing crate, so I suspect it is probably caused by Cargo features resolution. I personally bumped into this as well - apparently, building package alone and as part of workspace may result in usage of different features 🤯. See this issue in Cargo for more context.

@maciektr maciektr added this pull request to the merge queue May 29, 2024
Merged via the queue into software-mansion:main with commit f1aa7b0 May 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants