Make Scarb smarter when searching for Cargo binary #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit borrows the logic for looking for Cargo from Rust Analyzer, via its published `ra_ap_toolchain` crate. This change makes Scarb aware of: 1. The `CARGO` environment variable 2. The relatively well-known `$CARGO_HOME` directory This should make Scarb succeed to run `cargo fetch`/`build` when being run outside the interactive shell (i.e. without environment set by `rustup`). This includes running Scarb from CairoLS that is being run from a desktop application (like VSCode launched from macOS Dock). Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>
maciektr
approved these changes
Jun 4, 2024
THenry14
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit borrows the logic for looking for Cargo from Rust Analyzer, via its published
ra_ap_toolchaincrate.This change makes Scarb aware of:
CARGOenvironment variable$CARGO_HOMEdirectoryThis should make Scarb succeed to run
cargo fetch/buildwhen being run outside the interactive shell(i.e. without environment set by
rustup).This includes running Scarb from CairoLS that is being run from a desktop application (like VSCode launched from macOS Dock).