Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scarb expand initial impl #1344

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Scarb expand initial impl #1344

merged 1 commit into from
Jun 11, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Jun 6, 2024 •
edited
Loading

commit-id:8273b556

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@maciektr maciektr force-pushed the spr/main/8273b556 branch from d2330c2 to 3e8b479 Compare June 11, 2024 09:19
This was referenced Jun 11, 2024
Merged
Merged
@maciektr maciektr marked this pull request as ready for review June 11, 2024 09:19
@maciektr maciektr force-pushed the spr/main/8273b556 branch from 3e8b479 to 46b8ade Compare June 11, 2024 09:22
mkaput
mkaput reviewed Jun 11, 2024
View reviewed changes
scarb/src/ops/expand.rs Show resolved Hide resolved
scarb/src/ops/expand.rs Outdated Show resolved Hide resolved
THenry14
THenry14 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maciektr
Scarb expand initial impl
0309783 
commit-id:8273b556
@maciektr maciektr force-pushed the spr/main/8273b556 branch from 46b8ade to 0309783 Compare June 11, 2024 14:46
@maciektr maciektr enabled auto-merge June 11, 2024 14:46
@maciektr maciektr added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 1e920b0 Jun 11, 2024
44 checks passed
@maciektr maciektr deleted the spr/main/8273b556 branch June 11, 2024 16:00
@BrewTestBot BrewTestBot mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput left review comments

@THenry14 THenry14 THenry14 approved these changes

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciektr @mkaput @THenry14