Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge tools definition recursively #1353

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Merge tools definition recursively #1353

merged 2 commits into from
Jun 17, 2024

Conversation

maciektr
Copy link
Contributor

No description provided.

@maciektr maciektr requested a review from mkaput June 11, 2024 14:53
@maciektr maciektr marked this pull request as draft June 11, 2024 15:21
@maciektr maciektr force-pushed the maciektr/tools_merge branch from 3d91ecc to c4c76b9 Compare June 14, 2024 09:45
mkaput
mkaput requested changes Jun 14, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not forget writing docs on scarb website

scarb/src/internal/serdex.rs Show resolved Hide resolved
scarb/src/internal/serdex.rs Outdated Show resolved Hide resolved
@maciektr maciektr force-pushed the maciektr/tools_merge branch from c4c76b9 to 9510932 Compare June 14, 2024 14:49
@maciektr maciektr force-pushed the maciektr/tools_merge branch from 9510932 to 0649912 Compare June 17, 2024 08:37
@maciektr maciektr marked this pull request as ready for review June 17, 2024 08:37
@maciektr maciektr requested review from mkaput and THenry14 June 17, 2024 08:37
THenry14
THenry14 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

scarb/src/internal/serdex.rs Show resolved Hide resolved
@maciektr maciektr force-pushed the maciektr/tools_merge branch from 0649912 to 5d4c271 Compare June 17, 2024 09:14
@maciektr maciektr enabled auto-merge June 17, 2024 09:14
@maciektr maciektr added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit b86a512 Jun 17, 2024
22 checks passed
@maciektr maciektr deleted the maciektr/tools_merge branch June 17, 2024 10:04
@BrewTestBot BrewTestBot mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THenry14 THenry14 THenry14 approved these changes

@mkaput mkaput mkaput approved these changes

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciektr @mkaput @THenry14