Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cairo-test plugin to Scarb.toml manifest on new #1372

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

maciektr
Copy link
Contributor

No description provided.

Copy link
Member

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the scenario when this dep is added? Does that mean that cairo-test stays as the default test plugin in scarb? Sorry for potentially dumb questions, jsut trying to understand the impact :)

@maciektr
Copy link
Contributor Author

maciektr commented Jun 19, 2024

@THenry14
If you create a new package and run scarb test inside, it will try to run tests with cairo-test. As of now it will also fail to do so, as there is no cairo_test dependency in a newly created package.
You can create a package configured for snforge by using scarb init --snforge flag.

@maciektr maciektr force-pushed the maciektr/scarb-new branch from dd09155 to 909a463 Compare June 19, 2024 11:14
@maciektr maciektr requested a review from THenry14 June 19, 2024 11:32
@maciektr maciektr added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit 0750a15 Jun 19, 2024
22 checks passed
@maciektr maciektr deleted the maciektr/scarb-new branch June 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants