Make scarb new and init command interactive

[ksew1]

Closes #1207
Closes #1982

Make scarb new and init command interactive

[maciektr]

Would you be able to add any tests for that?

[ksew1]

Would you be able to add any tests for that?

Regarding the tests, the task is harder than it seemed. We can't run this as std::process::Command as it's not TTY. I tried PtyProcess, which works on my computer but not on CI. Additionally, this is platform-dependent, so it won't build on Windows. I don't know if it is really worth it.

We can write unit tests by adjusting the function signature as follows:

pub fn ask_for_test_runner<F>(prompt: F) -> Result<TestRunner>
where
    F: FnOnce(Vec<&str>) -> InquireResult<&str>

and then mocking the prompt.

However, if you think e2e tests are really important, I can try to research this topic further and maybe find a solution to run them.

[maciektr]

That's why I asked 😃

If it's too hard, I can live without tests (is this a problem with getting output only, or are the files not created on CI? 🤔 ). Unit approach is not worth it imho, as it mocks exactly what we would want to test in this scenario.

[ksew1]

That's why I asked 😃

If it's too hard, I can live without tests (is this a problem with getting output only, or are the files not created on CI? 🤔 ). Unit approach is not worth it imho, as it mocks exactly what we would want to test in this scenario.

The issue is getting input; it seems it is incorrectly passed. I haven't debugged it, though.

[maciektr]

Please make sure to use the new env var in snforge init after this is merged :D