-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package publish #1570
Merged
Merged
Add package publish #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THenry14
force-pushed
the
szymczyk/publish
branch
25 times, most recently
from
September 5, 2024 11:45
48d2074
to
a776a49
Compare
mkaput
requested changes
Sep 6, 2024
DelevoXDG
reviewed
Sep 6, 2024
DelevoXDG
reviewed
Sep 6, 2024
THenry14
force-pushed
the
szymczyk/publish
branch
from
September 6, 2024 13:41
e979d89
to
95b99ce
Compare
THenry14
force-pushed
the
szymczyk/publish
branch
from
September 6, 2024 13:53
95b99ce
to
ef6b9ad
Compare
THenry14
force-pushed
the
szymczyk/publish
branch
from
September 6, 2024 13:57
ef6b9ad
to
fca4cb5
Compare
mkaput
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from my side, though I didn't review this carefully (only picked stuff that interested me)
THenry14
force-pushed
the
szymczyk/publish
branch
from
September 6, 2024 19:35
1f65bea
to
a9f383a
Compare
maciektr
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a support for publishing packages to a registry.
In order to succesfully upload a package one needs to provide an authentication token via
SCARB_AUTH_TOKEN
env variable.