Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide docs for impls of hidden traits / traits with hidden generic args. #1644

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

maciektr
Copy link
Contributor

No description provided.

@maciektr maciektr changed the title Maciektr/doc hide impls Hide docs for impls of hidden traits / traits with hidden generic args. Oct 14, 2024
Copy link
Member

@wawel37 wawel37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

extensions/scarb-doc/src/types.rs Outdated Show resolved Hide resolved
@maciektr
Copy link
Contributor Author

@wawel37 I'll wait with merging for diagnostics to not introduce conflicts there

@maciektr maciektr force-pushed the maciektr/doc-hide-impls branch from 574fce7 to 9c13889 Compare October 14, 2024 21:53
@maciektr maciektr added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 3cda92a Oct 14, 2024
22 checks passed
@maciektr maciektr deleted the maciektr/doc-hide-impls branch October 14, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants