Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proc macro server API #1678

Merged
merged 0 commits into from
Nov 4, 2024
Merged

Proc macro server API #1678

merged 0 commits into from
Nov 4, 2024

Conversation

Draggu
Copy link
Contributor

@Draggu Draggu commented Oct 24, 2024 •
edited
Loading

This was referenced Oct 24, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
mkaput
mkaput requested changes Oct 25, 2024
View reviewed changes
utils/proc-macro-server-api/Cargo.toml Outdated Show resolved Hide resolved
utils/proc-macro-server-api/Cargo.toml Outdated
homepage.workspace = true
license.workspace = true
readme.workspace = true
repository.workspace = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is going to land on crates.io, then this is missing description and dedicated readme

utils/proc-macro-server-api/src/lib.rs Outdated

pub type RequestId = u64;

#[derive(Serialize, Deserialize)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc all of these

utils/proc-macro-server-api/src/methods/defined_macros.rs Outdated
use std::iter::Sum;

#[derive(Debug, Default, Serialize, Deserialize)]
pub struct DefinedMacrosResponse {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc all of these

utils/proc-macro-server-api/src/methods/expand.rs Outdated
use serde::{Deserialize, Serialize};

#[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Eq, Hash)]
pub struct ExpandAttributeParams {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc all of these

utils/proc-macro-server-api/src/methods/mod.rs Outdated
pub mod expand;

#[derive(Debug, Clone, Default, PartialEq, Eq, Hash, Serialize, Deserialize)]
pub struct ProcMacroResult {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc all of these

utils/proc-macro-server-api/Cargo.toml Outdated Show resolved Hide resolved
utils/proc-macro-server-api/src/lib.rs Outdated Show resolved Hide resolved
utils/proc-macro-server-api/src/methods/defined_macros.rs Outdated Show resolved Hide resolved
utils/proc-macro-server-api/src/methods/defined_macros.rs Outdated Show resolved Hide resolved
mkaput
mkaput requested changes Oct 25, 2024
View reviewed changes
utils/proc-macro-server-api/src/lib.rs Outdated Show resolved Hide resolved
@Draggu Draggu merged commit 0a3324e into spr/main/e5393b42 Nov 4, 2024
@Draggu Draggu force-pushed the spr/main/e5393b42 branch from 7e4347c to b07cfb1 Compare November 4, 2024 12:27
@Draggu Draggu force-pushed the spr/main/8fdc1e29 branch from 0b9efa9 to 0a3324e Compare November 4, 2024 12:27
@Draggu
Copy link
Contributor Author

Draggu commented Nov 4, 2024

Some spr issues, please continue here #1715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcticae Arcticae Arcticae left review comments

@mkaput mkaput mkaput requested changes

@maciektr maciektr Awaiting requested review from maciektr

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG

@wawel37 wawel37 Awaiting requested review from wawel37

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Draggu @mkaput @Arcticae