Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: executable command #1872

Open
wants to merge 1 commit into
base: spr/main/12d49314
Choose a base branch
from
Open

feat: executable command #1872

wants to merge 1 commit into from
+285 −0

Conversation

FroyaTheHen
Copy link
Contributor

@FroyaTheHen FroyaTheHen commented Jan 8, 2025 •
edited
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

closes #1814

@FroyaTheHen FroyaTheHen requested a review from a team as a code owner January 8, 2025 10:47
@FroyaTheHen FroyaTheHen mentioned this pull request Jan 8, 2025
Open
@FroyaTheHen
feat: executable command
8e3458e 
commit-id:c985abe1
FroyaTheHen
FroyaTheHen commented Jan 9, 2025
View reviewed changes
extensions/scarb-cairo-execute/tests/build.rs
String::from_utf8_lossy(&output.stderr),
);
let stdout = String::from_utf8_lossy(&output.stdout).to_string();
assert!(stdout.contains("Running hello"));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal, I did not use .stdout_matches(indoc! {... test windows and linux fails because of redundant white line. Cannot reproduce the error locally neither for zsh nor bash (both do create output with an extra white line making the test pass) or locate what causes the difference. Please advise if you have a better idea of know where lays the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FroyaTheHen