Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for installing nightlies in install script #571

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Add support for installing nightlies in install script #571

merged 1 commit into from
Aug 17, 2023

Conversation

szymmis
Copy link
Contributor

@szymmis szymmis commented Aug 16, 2023

Resolves #538

@szymmis szymmis requested a review from mkaput as a code owner August 16, 2023 07:31
maciektr
maciektr reviewed Aug 16, 2023
View reviewed changes
install.sh Outdated Show resolved Hide resolved
mkaput
mkaput reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity check: have you tested all of this manually? :)

mkaput
mkaput reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run checkbashisms install.sh. We technically do not target bash here :)

install.sh Outdated Show resolved Hide resolved
@szymmis szymmis force-pushed the szymmis/nightiles-support branch from 666b1d5 to 3d7d12a Compare August 17, 2023 09:52
@szymmis szymmis added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit e305fb8 Aug 17, 2023
@szymmis szymmis deleted the szymmis/nightiles-support branch August 17, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr left review comments

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support nightlies through installation script
3 participants
@szymmis @mkaput @maciektr