Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SerDe to save sierra program #610

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Use SerDe to save sierra program #610

merged 1 commit into from
Sep 6, 2023

Conversation

MrDenkoV
Copy link
Contributor

@MrDenkoV MrDenkoV commented Aug 24, 2023 •
edited
Loading

Fix #510

mkaput
mkaput reviewed Aug 25, 2023
View reviewed changes
extensions/scarb-cairo-run/src/main.rs Outdated Show resolved Hide resolved
extensions/scarb-cairo-run/src/main.rs Outdated Show resolved Hide resolved
scarb/tests/build.rs Outdated Show resolved Hide resolved
@MrDenkoV MrDenkoV force-pushed the mrdenkov/sierra_serde branch 2 times, most recently from b4df3c2 to e1a2044 Compare August 31, 2023 15:05
mkaput
mkaput requested changes Sep 1, 2023
View reviewed changes
scarb/src/compiler/compilers/lib.rs Show resolved Hide resolved
scarb/src/compiler/compilers/lib.rs Outdated Show resolved Hide resolved
extensions/scarb-cairo-run/src/main.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
mkaput
mkaput reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MrDenkoV MrDenkoV marked this pull request as ready for review September 5, 2023 13:02
@MrDenkoV MrDenkoV force-pushed the mrdenkov/sierra_serde branch from 5651970 to 3b843cc Compare September 5, 2023 14:58
@MrDenkoV MrDenkoV added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit 1f19099 Sep 6, 2023
@MrDenkoV MrDenkoV deleted the mrdenkov/sierra_serde branch September 6, 2023 07:27
@tserg tserg mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr left review comments

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace textual Sierra representation with JSON serialization of the Sierra struct
3 participants
@MrDenkoV @mkaput @maciektr