Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Cargo resolver version to 2 #618

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Set Cargo resolver version to 2 #618

merged 1 commit into from
Aug 28, 2023

Conversation

maciektr
Copy link
Contributor

No description provided.

@maciektr maciektr requested a review from mkaput as a code owner August 25, 2023 14:47
mkaput
mkaput approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t this change anything in the lock file ?

@maciektr
Copy link
Contributor Author

I am not getting any changes in Cargo.lock 👁️
My guess would be we are already using the 2 resolver, as we set edition to 2021 everywhere, so this just gets rid of the warning.

scarb/Cargo.toml

Line 18 in 05b5bc1

edition = "2021"

@maciektr maciektr added this pull request to the merge queue Aug 28, 2023
Merged via the queue into main with commit b24bdba Aug 28, 2023
@maciektr maciektr deleted the maciektr/ws-resolver branch August 28, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciektr @mkaput