Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying custom source patches #791

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Allow specifying custom source patches #791

merged 3 commits into from
Oct 16, 2023

Conversation

szymmis
Copy link
Contributor

@szymmis szymmis commented Oct 12, 2023

No description provided.

@szymmis szymmis requested a review from mkaput as a code owner October 12, 2023 11:33
@szymmis szymmis force-pushed the szymmis/custom-source-patches branch from a520270 to 42b274c Compare October 12, 2023 11:41
mkaput
mkaput reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarrencev can you please check this out and verify it works for you? 😃

I'll approve this PR when we'll get confirmation this works in Sozo.

scarb/src/core/config.rs Show resolved Hide resolved
tarrencev
tarrencev reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@tarrencev tarrencev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Just to be sure, we'll plan to call this when building the config here: https://github.com/dojoengine/dojo/blob/76b6e4ad61fa8b3a54e55c4455aec5bf02521c98/crates/sozo/src/main.rs#L35

scarb/src/core/config.rs Show resolved Hide resolved
@szymmis szymmis force-pushed the szymmis/custom-source-patches branch from 49b71d6 to dd878ad Compare October 16, 2023 09:34
@szymmis szymmis enabled auto-merge October 16, 2023 09:43
@szymmis szymmis force-pushed the szymmis/custom-source-patches branch from dd878ad to 8fcdd4c Compare October 16, 2023 11:11
@szymmis szymmis added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit d50ddaf Oct 16, 2023
@szymmis szymmis deleted the szymmis/custom-source-patches branch October 16, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrencev tarrencev tarrencev left review comments

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szymmis @mkaput @tarrencev