Make profile args take precedence over env #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaput
requested changes
Oct 25, 2023
There was a problem hiding this comment.
I wonder if it wouldn't be better to allow multiple arguments in ProfileSpec group and employ overriding logic (--dev takes over --release which takes over --profile). Because we essentialy also have this problem if the user sets export SCARB_PROFILE=... in their .rc file etc.
maciektr
reviewed
Oct 25, 2023
szymmis
force-pushed
the
szymmis/run-scripts-profile
branch
from
f3cfe3a to
fde42f2
Compare
szymmis
force-pushed
the
szymmis/run-scripts-profile
branch
from
fde42f2 to
4d6b1ed
Compare
maciektr
approved these changes
Oct 25, 2023
szymmis
force-pushed
the
szymmis/run-scripts-profile
branch
from
4d6b1ed to
b6f8a5f
Compare
mkaput
pushed a commit
that referenced
this pull request
Oct 30, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
Fixes #849 Removing a test when it's failing isn't a good idea but `cannot_choose_both_release_and_dev` test that created from `cannot_choose_both_release_and_by_name` (in #825) is a duplicate of `cannot_choose_both_dev_and_release` test. It could be fixed by adjusting stderr message assertion to ```sh Usage: scarb[..] --dev --global-cache-dir <DIRECTORY> --global-config-dir <DIRECTORY> <COMMAND> ``` but that would be the exact same thing as `cannot_choose_both_dev_and_release`.
tomek0123456789
pushed a commit
that referenced
this pull request
Nov 8, 2023
Fixes #849 Removing a test when it's failing isn't a good idea but `cannot_choose_both_release_and_dev` test that created from `cannot_choose_both_release_and_by_name` (in #825) is a duplicate of `cannot_choose_both_dev_and_release` test. It could be fixed by adjusting stderr message assertion to ```sh Usage: scarb[..] --dev --global-cache-dir <DIRECTORY> --global-config-dir <DIRECTORY> <COMMAND> ``` but that would be the exact same thing as `cannot_choose_both_dev_and_release`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #823