Support RPC 0.4.0 #281

DelevoXDG · 2023-07-25T13:57:15Z

Describe your changes

Updated Message dataclasses, get_estimate_message_fee
Added execution_status, finality_status, revert_reason to TransactionReceipt
Updated Transaction dataclasses, added DeclareTransactionV0 dataclass
~~Updated BlockWithTx~~
Bumped devnet to 0.6.0
Added mock tests: adjust to pythonic devnet not having RPC 0.4.0 support
Added integration tests

Linked issues

Closes #280
Closes #270
Closes #262

Breaking changes

This issue contains breaking changes

Changes to TransactionReceipt dataclasses
Changes to Message dataclasses, get_estimate_message_fee

DelevoXDG · 2023-07-25T14:05:51Z

We should review current changes, but block this until devnet update arrives or at least there's some clarity regarding what changes will be included in the release so it is reasonable to write mock tests.

...in/com/swmansion/starknet/data/serializers/JsonRpcTransactionReceiptPolymorphicSerializer.kt

lib/src/main/kotlin/com/swmansion/starknet/data/serializers/TransactionPolymorphicSerializer.kt

lib/src/main/kotlin/com/swmansion/starknet/data/types/Messages.kt

lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/Transaction.kt

lib/src/test/kotlin/starknet/account/StandardAccountTest.kt

...in/com/swmansion/starknet/data/serializers/JsonRpcTransactionReceiptPolymorphicSerializer.kt

lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/Transaction.kt

DelevoXDG · 2023-07-25T14:45:25Z

lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/Transaction.kt

+    @JsonNames("calldata")
+    val constructorCalldata: Calldata,
+
+    // TODO: check whether this should actually be contract_class in case of gateway


It appears that class_hash is used in gateway as well

...in/com/swmansion/starknet/data/serializers/JsonRpcTransactionReceiptPolymorphicSerializer.kt

lib/src/main/kotlin/com/swmansion/starknet/data/serializers/TransactionPolymorphicSerializer.kt

lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/Transaction.kt

...in/com/swmansion/starknet/data/serializers/JsonRpcTransactionReceiptPolymorphicSerializer.kt

… to avoid errors

THenry14

Great job mate 🔥 only a few smaller comments

.github/workflows/checks.yml

integration_tests_config_template.env

THenry14 · 2023-08-17T05:34:13Z

lib/src/main/kotlin/com/swmansion/starknet/data/types/Responses.kt

-    @SerialName("parent_hash")
-    override val parentHash: Felt,
+    // Not in RPC schema
+    // TODO: remove this when Pathfinder is updated


let's improve the comment, so it is clear what is to be removed then. Ideally, there should be an issue number stated here, under which more extensive description shall be written.

lib/src/main/kotlin/com/swmansion/starknet/signer/StarkCurveSigner.kt

lib/src/test/kotlin/integration/provider/ProviderTest.kt

lib/src/test/kotlin/integration/account/AccountTest.kt

lib/build.gradle.kts

…example config

…nitialization

war-in

Great job 🔥 Let's wait with merging until @THenry14 approves too

lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/Transaction.kt

lib/src/test/kotlin/integration/account/AccountTest.kt

.github/workflows/checks.yml

DelevoXDG and others added 10 commits July 14, 2023 11:44

Bump starknet-devnet to 0.5.5

525b710

Update Messages to match openrpc 0.4.0-rc spec

a362f21

Add getEstimateMessageFee (untested)

86178d1

Merge branch 'main' into feat/estimate_message_fee-rpc-0.4.0

fa13547

Update naming (MessageL2ToL1) in SimulatedTransaction

a86c07e

Merge branch 'main'

c3705a8

Split DeclareTransaction to match oneOf (rpc 0.4.0-rc2)

11e7ce5

Add execution_status, finality_status, revert_reason

5f8936f

Add TransactionHashPair to support new block body (rpc 0.4.0-rc2)

6303c4b

Update transactions (rpc 0.4.0-rc2)

1282a94

DelevoXDG marked this pull request as draft July 25, 2023 13:57

DelevoXDG requested a review from THenry14 July 25, 2023 14:00

DelevoXDG added enhancement New feature or request blocked labels Jul 25, 2023

Update deserializers

274a4b1

DelevoXDG removed blocked enhancement New feature or request labels Jul 25, 2023

Txn hash also removed from L1_Handler in RPC

d443aea

THenry14 reviewed Jul 26, 2023

View reviewed changes

DelevoXDG added 5 commits July 26, 2023 10:47

Remove "to_address" from GatewayMessageL1ToL2

47a7367

Set correct version in DeclareTransactionV2

f45981b

Add entry_point_selector to RpcMessageL1ToL2

43ef424

Add extra options to execution and finality status (starknet 0.12.1)

c4de245

Set non-required (in rpc 0.4) dataclass fields to null

0a9b524

war-in reviewed Jul 27, 2023

View reviewed changes

DelevoXDG added 3 commits July 27, 2023 14:17

Restore the old order of fields in Transactions

a4a47f8

Finish restoring order

a4db374

Fix order 3

b6141f6

DelevoXDG commented Jul 28, 2023

View reviewed changes

DelevoXDG and others added 7 commits August 16, 2023 18:07

Bump devnet to 0.6.0; Set different salt in tests for Gateway and RPC…

fcfcb5d

… to avoid errors

Remove PascalCase

59afff4

Accept both revert_reason and revert_error

b4a6cb1

Recalculate classHashes (cairo 0) - 0.12.1

73f8242

Rename GettersTest to ProviderTest

36ed534

Reenable non-gas integration tests on CI

7f67222

Remove beforeEach from integration.account test

0bb3544

THenry14 reviewed Aug 17, 2023

View reviewed changes

DelevoXDG added 4 commits August 17, 2023 12:23

Disable int tests by default; Add int instructions to README; Rename …

f807a9a

…example config

Rename ConfigUtils to IntegrationConfig; Speed up IntegrationConfig i…

77cc9a6

…nitialization

Format

6a9e6c9

Update hooks in readme

8e34445

war-in approved these changes Aug 17, 2023

View reviewed changes

lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/Transaction.kt Outdated Show resolved Hide resolved

lib/src/test/kotlin/integration/account/AccountTest.kt Outdated Show resolved Hide resolved

DelevoXDG added 12 commits August 17, 2023 14:39

Add DeclareTransactionV0 and test

dd8f123

Update .gitignore

01c825e

Format

d1f7a25

Format; Clarify README

b0bc4ea

Remove irrelevant TODO

d8bd4b0

Add extra integration tests

b871031

Disable integration tests on CI

d342bc9

Replace integration test variables with INTEGRATION_TEST_MODE

66e81dd

Add call contract integration test

dd23fef

Add mock test for pending transaction receipt

c607874

Drop STARKNET_JVM prefix from CI secrets

1d6f89e

Misc changes

acbcbe0

THenry14 approved these changes Aug 18, 2023

View reviewed changes

.github/workflows/checks.yml Outdated Show resolved Hide resolved

DelevoXDG added 2 commits August 18, 2023 15:28

Remove loading env vars on CI

3c482d6

Make empty config when integrationTestMode=disabled

075aa01

DelevoXDG merged commit e00a195 into main Aug 18, 2023
2 checks passed

DelevoXDG deleted the feat/support-rpc-0.4.0 branch September 28, 2023 13:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support RPC 0.4.0 #281

Support RPC 0.4.0 #281

DelevoXDG commented Jul 25, 2023 •

edited

Loading

DelevoXDG commented Jul 25, 2023 •

edited

Loading

DelevoXDG Jul 25, 2023

THenry14 left a comment

THenry14 Aug 17, 2023

war-in left a comment

Support RPC 0.4.0 #281

Support RPC 0.4.0 #281

Conversation

DelevoXDG commented Jul 25, 2023 • edited Loading

Describe your changes

Linked issues

Breaking changes

DelevoXDG commented Jul 25, 2023 • edited Loading

DelevoXDG Jul 25, 2023

Choose a reason for hiding this comment

THenry14 left a comment

Choose a reason for hiding this comment

THenry14 Aug 17, 2023

Choose a reason for hiding this comment

war-in left a comment

Choose a reason for hiding this comment

DelevoXDG commented Jul 25, 2023 •

edited

Loading

DelevoXDG commented Jul 25, 2023 •

edited

Loading