Update MerkleTree to allow Poseidon hashing #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `MerkleHashFunction` enum - `MerkleTree` now accepts `hashFunction` as an optinal argument - (breaking) `MerkleTree.hash` now requires `hashFunction` to be specified
- Move to package com.swmansion.starknet.crypto - Implement using abstract function instead of stored lambda
DelevoXDG
commented
Mar 13, 2024
DelevoXDG
commented
Mar 14, 2024
THenry14
reviewed
Mar 14, 2024
THenry14
approved these changes
Mar 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
==========================================
+ Coverage 70.33% 70.37% +0.04%
==========================================
Files 72 73 +1
Lines 3148 3153 +5
Branches 309 309
==========================================
+ Hits 2214 2219 +5
Misses 788 788
Partials 146 146 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related to and is needed for #428
HashMethodenumoptionalmandatoryhashFunctionparameter toMerkleTreeconstructorhashFunctionparameter toMerkleTree.hash()methodLinked issues
Closes
Breaking changes
MerkleTreeconstructor now requires ahashFunctionargument to be passedMerkleTree.hash()static method now requires ahashFunctionargument to be passed