Add StandardAccount.create()
#501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
changed the title
StandardAccountStandardAccount to static method
franciszekjob
changed the title
StandardAccount to static methodStandardAccount creation with automatic determination of Cairo version to static method
franciszekjob
commented
Jul 24, 2024
Comment on lines
89
to
98
| @Test | ||
| fun `creating account with automatic Cairo version determination`() { | ||
| StandardAccount.create( | ||
| address = accountAddress, | ||
| privateKey = Felt(1234), | ||
| provider = provider, | ||
| chainId = chainId, | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
note: It would be ideal if we could check resolved cairoVersion and compare it with expected value. However, cairoVersion is a private field, so we cannot do this. Wdyt @ddoktorski ?
There was a problem hiding this comment.
Perhaps we can add a test similar to cairo1 account calldata? Would it be possible to use Cairo 0 account?
There was a problem hiding this comment.
Yes, I've added test both for Cairo 0 and 1.
franciszekjob
changed the title
StandardAccount creation with automatic determination of Cairo version to static methodStandardAccount.create()
ddoktorski
reviewed
Jul 25, 2024
lib/src/main/kotlin/com/swmansion/starknet/account/StandardAccount.kt
Outdated
Show resolved
Hide resolved
Comment on lines
89
to
98
| @Test | ||
| fun `creating account with automatic Cairo version determination`() { | ||
| StandardAccount.create( | ||
| address = accountAddress, | ||
| privateKey = Felt(1234), | ||
| provider = provider, | ||
| chainId = chainId, | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
Perhaps we can add a test similar to cairo1 account calldata? Would it be possible to use Cairo 0 account?
ddoktorski
reviewed
Jul 25, 2024
Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
ddoktorski
approved these changes
Jul 26, 2024
franciszekjob
deleted the
feat/383-2-automatically-determine-cairo-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
StandardAccountconstructor withcairoVersionparamcairoVersiontoCairoVersion.ONEStandardAccount.create(), which allows to create aStandardAccountinstance with automatic determination of Cairo versionLinked issues
Closes
Breaking changes