Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StandardAccount.generatePrivateKey() #507

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Aug 5, 2024

Describe your changes

Allow users to generate random private key.

  • Add static method StandardAccount.generatePrivateKey() used to generated random private key

Linked issues

Closes #506

Breaking changes

  • This issue contains breaking changes

Comment on lines +159 to +162

// You can also generate a random private key
Felt randomPrivateKey = StarknetCurve.generatePrivateKey();

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Example of generating account with random/own private key could be split into separate subsections. For now, I've added it as follows, but general guide and examples will be improved in #504.

Copy link

@kkawula kkawula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciszekjob franciszekjob merged commit 56d1665 into main Aug 29, 2024
2 checks passed
@franciszekjob franciszekjob deleted the feat/506-private-key-generation branch August 29, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method to generate private key
2 participants