Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/9 #13

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Fix/9 #13

merged 2 commits into from
Dec 28, 2022

Conversation

adamwawrzynski
Copy link
Collaborator

@adamwawrzynski adamwawrzynski commented Dec 28, 2022 •
edited
Loading

Description

This PR resolves issue #9. This PR adds model.eval() function in example/streamlit_app/model_utils.py script to remove all dropouts and bumps patch version of package.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • manual tests of demo app

Checklist:

  • I have updated all related pyproject.toml files.
  • I have updated lock files.
  • I have set an Assignee and Reviewers.
  • I have labeled the PR correctly.
  • I have performed a self-review of my own code.
  • I have covered my code and changes with unit tests.
  • I have annotated types as extensively as possible.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • All code references and dependencies will work.

Adam Wawrzyński added 2 commits December 28, 2022 10:06
Setup loaded model to eval mode
989c252 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Bump patch version
44ad45f 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
@adamwawrzynski adamwawrzynski self-assigned this Dec 28, 2022
@adamwawrzynski adamwawrzynski added the bug Something isn't working label Dec 28, 2022
@adamwawrzynski adamwawrzynski marked this pull request as ready for review December 28, 2022 09:12
@adamwawrzynski adamwawrzynski merged commit ad9f232 into main Dec 28, 2022
@adamwawrzynski adamwawrzynski mentioned this pull request Dec 28, 2022
Closed
@adamwawrzynski adamwawrzynski deleted the fix/9 branch February 13, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilrzechowski kamilrzechowski kamilrzechowski approved these changes

@adamjankaczmarek adamjankaczmarek Awaiting requested review from adamjankaczmarek

Assignees

@adamwawrzynski adamwawrzynski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamwawrzynski @kamilrzechowski