Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract visualization functions from Explainer to standalone function… #55

Merged
merged 11 commits into from
Feb 6, 2023
Merged

Extract visualization functions from Explainer to standalone function… #55

merged 11 commits into from
Feb 6, 2023

Conversation

adamwawrzynski
Copy link
Collaborator

@adamwawrzynski adamwawrzynski commented Jan 25, 2023 •
edited
Loading

Description

This PR introduces visualization function to display single channel of attributes heatmaps. It also extracts visualize method from Explainer class into standalone functions.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • successful run of notebook

Checklist:

  • I have updated all related pyproject.toml files.
  • I have updated lock files.
  • I have set an Assignee and Reviewers.
  • I have labeled the PR correctly.
  • I have performed a self-review of my own code.
  • I have covered my code and changes with unit tests.
  • I have annotated types as extensively as possible.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • All code references and dependencies will work.

Extract visualization functions from Explainer to standalone function…
0258fff 
…s, add visualization of single channel

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
@adamwawrzynski adamwawrzynski self-assigned this Jan 25, 2023
@adamwawrzynski adamwawrzynski added the enhancement New feature or request label Jan 25, 2023
Fix callback visualization
b606e83 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Adam Wawrzyński added 2 commits January 25, 2023 15:01
Adam Wawrzyński added 2 commits January 25, 2023 20:20
Add missing docstring
992f439 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Remove duplicated pre-processing code in single channel visualization
222401d 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
rpytel1
rpytel1 reviewed Jan 26, 2023
View reviewed changes
autoxai/visualizer.py Outdated Show resolved Hide resolved
@rpytel1
Copy link
Collaborator

rpytel1 commented Jan 26, 2023

LGTM!

kamilrzechowski
kamilrzechowski reviewed Jan 26, 2023
View reviewed changes
autoxai/visualizer.py Outdated Show resolved Hide resolved
autoxai/visualizer.py Outdated Show resolved Hide resolved
Adam Wawrzyński added 2 commits January 30, 2023 11:23
Replace assert with raising exception in visualization of single chan…
a8bb8c1 
…nel attributes, add unit tests

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Separate standardization and convertion of an array, add unit tests
22df198 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
kamilrzechowski
kamilrzechowski approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@kamilrzechowski kamilrzechowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

autoxai/array_utils.py Show resolved Hide resolved
tests/test_visualizer.py Outdated Show resolved Hide resolved
Adam Wawrzyński added 2 commits February 2, 2023 11:03
Add checking type of array to standardize
b373282 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Change data type of tensors in unit tests, add casting in visualizati…
428859d 
…on pre-processing func

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
@adamwawrzynski adamwawrzynski merged commit e625241 into main Feb 6, 2023
@adamwawrzynski adamwawrzynski deleted the feat/visualization_per_channel branch February 6, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpytel1 rpytel1 rpytel1 approved these changes

@adamjankaczmarek adamjankaczmarek Awaiting requested review from adamjankaczmarek

@kamilrzechowski kamilrzechowski Awaiting requested review from kamilrzechowski

Assignees

@adamwawrzynski adamwawrzynski

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamwawrzynski @rpytel1 @kamilrzechowski