Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GradCAM for object detection #75

Merged
merged 39 commits into from
May 22, 2023
Merged

Add GradCAM for object detection #75

merged 39 commits into from
May 22, 2023

Conversation

adamwawrzynski
Copy link
Collaborator

@adamwawrzynski adamwawrzynski commented Apr 4, 2023 •
edited
Loading

Description

This PR introduces GradCAM algorithm for object detection task with 2 network examples: YOLOv5 and SSD. Refactoring and modification of the module structure were applied.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • pre-commit
  • poetry run python3 example/mnist_wandb.py
  • run example/gradcam/object_detection.ipynb

Checklist:

  • I have updated all related pyproject.toml files.
  • I have updated lock files.
  • I have set an Assignee and Reviewers.
  • I have labeled the PR correctly.
  • I have performed a self-review of my own code.
  • I have covered my code and changes with unit tests.
  • I have annotated types as extensively as possible.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • All code references and dependencies will work.

Adam Wawrzyński added 15 commits March 24, 2023 16:40
Add example with GradCAM for YOLOv5 in object detection
bb9aace 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Remove constraints for min and max bbox size
95ebde4 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Extract base ObjectDetector class
800d316 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Remove previous example with object detection task
7bf25d7 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Add original code source URL in docstring
0e06077 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Move fetching layer from YOLO model function, add target_layer parame…
3cb9096 
…ter to GradCAM

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Add dataclasses for complex object detection output data types
b0a2f72 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Refactor code, add docstrings, fix names, add workaround with np.abs …
a109c95 
…for bbox coordinates

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Add support for torchvision SSD model for object detection, refactoring
729b160 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Rename directories
cba9096 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Refactor, change BaseObjectDetector class definition, make SSD model …
c668ea0 
…inherit from it

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Refactor modules structure, add GradCAM to object detection module
4c64201 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Remove unused imports
80675b6 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Refactor, move OD models to separate module, fix YOLO prediction gene…
5202503 
…ration

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Apply pre-commit hooks to all files
f07bddc 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
@adamwawrzynski adamwawrzynski self-assigned this Apr 4, 2023
@adamwawrzynski adamwawrzynski added the enhancement New feature or request label Apr 4, 2023
@adamwawrzynski adamwawrzynski linked an issue Apr 4, 2023 that may be closed by this pull request
[Fix] Add support for Object Detection #73
Closed
Adam Wawrzyński added 6 commits April 5, 2023 16:04
Replace excessive unnecessary dependency with simple parsing
6c4d599 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Remove model warmup run
1cf27ba 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Remove unused path in forward pass algorithm
3d628be 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Replace custom implementations with torchvision imports
9cc543e 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Add unit tests for object detection utils
2a3654b 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Remove obsolete directory
74f3af3 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
@adamwawrzynski adamwawrzynski requested review from rpytel1 and removed request for adamjankaczmarek and rpytel1 April 7, 2023 09:36
@adamwawrzynski adamwawrzynski requested review from rpytel1 and kamilrzechowski and removed request for adamjankaczmarek April 7, 2023 09:39
Adam Wawrzyński added 3 commits April 11, 2023 11:12
Fix YOLOv5 bbox conversion
dba4220 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Add unit test for object detection visualization utils, refactor
e8ca464 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Refactor GradCAM for OD
615b29f 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Adam Wawrzyński added 3 commits April 26, 2023 14:05
Remove redundant device argument to YOLOv5ObjectDetector class initia…
74bd96a 
…lizer

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Fix unit tests for image preprocessing - use rectangle instead of squ…
671a6a6 
…are shapes

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Simplify forward function in WrapperYOLOv5ObjectDetectionModule class
e9caa21 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
@rpytel1 rpytel1 mentioned this pull request May 9, 2023
Merged
13 tasks
Add custom GradCAM base algorithm implementation for classification a…
2ef603e 
…nd object detection

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Adam Wawrzyński added 5 commits May 16, 2023 08:24
Move object detection model examples to examples directory
c716d68 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Restructure library directory structure for explainer algorithms, mov…
3de8d7c 
…e object detection example script to notebook

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Add interpolation method parameter to resize_image function
b6adfe5 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Fix unit tests and imports
77fa17a 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Remove adding epsilon in preprocess object detection image function
bc0b278 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Adam Wawrzyński added 6 commits May 17, 2023 18:38
Fix example notebook - add assertions of YOLOv5 image shape
cc968da 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Fix basic usage notebook after refactoring class names and directory …
581c4f4 
…structure

Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Enable changing image ratio to match YOLOv5 requirements of image shape
734dd22 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Update README
18f8c40 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Refactor object detection custom modules
4d811a1 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
Refactor GradCAM for object detection
b146038 
Signed-off-by: Adam Wawrzyński <adam.wawrzynski@reasonfieldlab.com>
rpytel1
rpytel1 approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@rpytel1 rpytel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 Lets merge!

@adamwawrzynski adamwawrzynski merged commit 26b31ef into main May 22, 2023
@adamwawrzynski adamwawrzynski deleted the feat/gradcam_object_detection branch May 22, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpytel1 rpytel1 rpytel1 approved these changes

@kamilrzechowski kamilrzechowski Awaiting requested review from kamilrzechowski

Assignees

@adamwawrzynski adamwawrzynski

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] Add support for Object Detection
3 participants
@adamwawrzynski @rpytel1 @kamilrzechowski