added test for nullable schemas

softwaremill · Apr 22, 2024 · 8807c3f · 8807c3f
1 parent d0a8fa9
commit 8807c3f
Showing 1 changed file with 19 additions and 0 deletions.
diff --git a/apispec-model/src/test/scala/sttp/apispec/validation/SchemaComparatorTest.scala b/apispec-model/src/test/scala/sttp/apispec/validation/SchemaComparatorTest.scala
@@ -121,6 +121,8 @@ class SchemaComparatorTest extends AnyFunSuite {
     assert(compare(ref("Something"), ref("Something")) == List(
       TypeMismatch(List(SchemaType.String), List(SchemaType.Integer))
     ))
+    assert(compare(ref("Integer"), ref("Something")) == Nil)
+    assert(compare(ref("Something"), ref("String")) == Nil)
   }
 
   test("recursive schemas") {
@@ -130,6 +132,23 @@ class SchemaComparatorTest extends AnyFunSuite {
     ))
   }
 
+  test("nullable schemas") {
+    assert(compare(stringSchema, stringSchema.nullable) == Nil)
+    assert(compare(opaqueSchema, opaqueSchema.nullable) == Nil)
+    assert(compare(ref("String"), ref("String").nullable) == Nil)
+    assert(compare(integerSchema.nullable, numberSchema.nullable) == Nil)
+
+    assert(compare(stringSchema.nullable, stringSchema) == List(
+      TypeMismatch(List(SchemaType.Null), List(SchemaType.String))
+    ))
+    assert(compare(opaqueSchema.nullable, opaqueSchema) == List(
+      GeneralSchemaMismatch(opaqueSchema.nullable, opaqueSchema) //TODO better issue?
+    ))
+    assert(compare(ref("String").nullable, ref("String")) == List(
+      GeneralSchemaMismatch(ref("String").nullable, stringSchema) //TODO better issue?
+    ))
+  }
+
   test("enum and const mismatch") {
     def enums(values: Any*): List[ExampleSingleValue] =
       values.toList.map(ExampleSingleValue)