Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Override blocking inside CatsMonadError #1992

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

flipp5b
Copy link
Contributor

@flipp5b flipp5b commented Nov 7, 2023

Fix #1991

@flipp5b
Copy link
Contributor Author

flipp5b commented Nov 7, 2023

@adamw, I added a test reproducing the issue to the JVM test root. It looks like everything works except JS tests. But I can't figure out why.

@adamw
Copy link
Member

adamw commented Nov 7, 2023

@flipp5b argh it's something with chrome driver again :/

[error] Caused by: org.openqa.selenium.SessionNotCreatedException: session not created: This version of ChromeDriver only supports Chrome version 114
[error] Current browser version is 118.0.5993.117 with binary path /usr/bin/google-chrome

I've been fixing this lately, I'll take a look later

@adamw
Copy link
Member

adamw commented Nov 7, 2023

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Nov 7, 2023

rebase

✅ Branch has been successfully rebased

@adamw
Copy link
Member

adamw commented Nov 7, 2023

ah it's for the v3 branch ... I updated its build plugins, let's see
could you submit a PR for master later as well?

@flipp5b flipp5b changed the title Override blocking inside CatsMonadError [v3] Override blocking inside CatsMonadError Nov 7, 2023
@flipp5b
Copy link
Contributor Author

flipp5b commented Nov 7, 2023

Done: #1993.

@adamw adamw merged commit da22511 into softwaremill:v3 Nov 8, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants