New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support to the Curl backend #2007

Merged

adamw merged 1 commit into softwaremill:master from JD557:native-windows-support

Nov 26, 2023

Contributor

JD557 commented Nov 25, 2023 •

edited

Loading

Before submitting pull request:

Check if the project compiles by running sbt compile
Verify docs compilation by running sbt compileDocs
Check if tests pass by running sbt test (I had some issues with some tests, so I'll wait for the CI, but I did check that this worked locally on Windows with sn-vcpkg)
Format code by running sbt scalafmt

On Windows, curl needs to be linked as libcurl instead of curl. On top of that, it requires crypt32.

I'm using a strategy similar to what Scala Native 0.5.0 uses to handle a similar problem with ZLib. See:

https://github.com/scala-native/scala-native/blob/12d57c527d241f6a1781ec9457492cdd6cc4a904/javalib/src/main/scala/scala/scalanative/ffi/zlib.scala#L8-L19

https://github.com/scala-native/scala-native/blob/main/javalib/src/main/scala/scala/scalanative/ffi/package.scala#L7

I was only able to test this on Windows, so please check if nothing is broken in Linux/MacOS.


Add Windows support to the Curl backend

273451a

adamw merged commit 0ce7e08 into softwaremill:master

12 checks passed

Member

adamw commented Nov 26, 2023

Thank you!

JD557 deleted the native-windows-support branch

November 26, 2023 20:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment