Make AbstractCurlBackend async friendly #2012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some structural changes to make implementing an async Curl backend (e.g. with
curl_multi_*
) possible asa subclass of
AbstractCurlBackend
.Mainly:
CurlHandle -> F[CurlCode]
method,performCurl
. This can be done withcurl_multi_*
instead of just
curl_easy_perform
. Also seems to be the only thing needed to be changed.We might have to change
curl.option
calls as well, if we want to properly handle them as monadic calls.Before submitting pull request:
sbt compile
sbt compileDocs
sbt test
sbt scalafmt