Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scala-js fetch manual abort v4 #2073

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

ThijsBroersen
Copy link
Contributor

@ThijsBroersen ThijsBroersen commented Feb 7, 2024

This PR implements cancellation of fetch-request when effects are interrupted.
I tested it manually with a local project. I was unsure on how to adjust/add a unit test to validate the behaviour.

Before submitting pull request:

  • Check if the project compiles by running sbt compile
  • Verify docs compilation by running sbt compileDocs
  • Check if tests pass by running sbt test --> could not run the tests because I don't have the required browser
  • Format code by running sbt scalafmt

@adamw adamw merged commit 3e5d3f6 into softwaremill:master Feb 8, 2024
12 checks passed
@adamw
Copy link
Member

adamw commented Feb 8, 2024

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants