-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Scala 3 Constant and Union support for string-based literals as enums #3846
Merged
adamw
merged 6 commits into
softwaremill:master
from
ThijsBroersen:feat-scala3-string-based-union-literal-enum-support
Jun 17, 2024
Merged
feat: implement Scala 3 Constant and Union support for string-based literals as enums #3846
adamw
merged 6 commits into
softwaremill:master
from
ThijsBroersen:feat-scala3-string-based-union-literal-enum-support
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Jun 14, 2024
adamw
reviewed
Jun 14, 2024
adamw
reviewed
Jun 14, 2024
core/src/main/scala-3/sttp/tapir/macros/LowPrioSchemaMacrosVersionSpecific.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Jun 14, 2024
Thanks for the PR! I think for completeness it would also be great to have |
@adamw thanks for the feedback, will process it probably tonight. |
process feedback simplify macro
Added both Codec and Validator derivations. Schema and Codec reuse the Validator now. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for string-based literal types. Single-value or Union-based.
Example: