Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: fix oneOf types without common parent for scala 3 #4261

Merged
merged 1 commit into from
Jan 13, 2025
Merged

codegen: fix oneOf types without common parent for scala 3 #4261

merged 1 commit into from
Jan 13, 2025

Conversation

hughsimpson
Copy link
Contributor

@hughsimpson hughsimpson commented Jan 11, 2025 •
edited
Loading

Fixes return LUB type for return type when generating endpoints with response objects without a common parent in scala 3 (was generating Some(Foo) | Some(Bar) instead of Foo | Bar 🤦)

@adamw adamw merged commit 4c8fe25 into softwaremill:master Jan 13, 2025
28 checks passed
@adamw
Copy link
Member

adamw commented Jan 13, 2025

Thanks :)

@hughsimpson hughsimpson deleted the fix_endpoint_types_for_scala_3 branch January 13, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hughsimpson @adamw