Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe governance and restructure website and repo scopes #295

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

sdruskat
Copy link
Contributor

@sdruskat sdruskat commented Dec 9, 2024

Fix #287

@sdruskat sdruskat marked this pull request as ready for review December 10, 2024 08:46
@sdruskat
Copy link
Contributor Author

@softwarepub/core and @softwarepub/hermes-steering-group Please review, especially carefully for GOVERNANCE.md.

Comment on lines +56 to +58
- Stephan Druskat (DLR), stephan.druskat@dlr.de
- David Pape (HZDR)
- Nitai Heeb (FZJ)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Stephan Druskat (DLR), stephan.druskat@dlr.de
- David Pape (HZDR)
- Nitai Heeb (FZJ)
- Stephan Druskat (DLR), stephan.druskat@dlr.de
- David Pape (HZDR), d.pape@hzdr.de
- Nitai Heeb (FZJ), n.heeb@fz-juelich.de

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I wanted to see first if @zyzzyxdonta and @nheeb wanted their emails in there or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not 🤷🏻‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nheeb? Are you happy to have your email listed?

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
@zyzzyxdonta
Copy link
Contributor

zyzzyxdonta approved these changes on behalf of softwarepub/hermes-steering-group

I'm not a fan of this phrasing because it can contradict in certain cases the rules laid out in GOVERNANCE.md 🤷🏻‍♂️

@sdruskat
Copy link
Contributor Author

zyzzyxdonta approved these changes on behalf of softwarepub/hermes-steering-group

I'm not a fan of this phrasing because it can contradict in certain cases the rules laid out in GOVERNANCE.md 🤷🏻‍♂️

Huh, interesting automatism. Let me check if there is a switch I can flip so that this doesn't appear. I can't see how I'd have triggered this through review invitations.

In any case, this change is critical enough to warrant more thorough reviews, calling @led02, @poikilotherm, @nheeb.

@sdruskat
Copy link
Contributor Author

Let me check if there is a switch I can flip so that this doesn't appear. I can't see how I'd have triggered this through review invitations.

@zyzzyxdonta Yea, this seems to have been triggered through the invitation of the group. These are the options for the team setup and code review:

grafik

At least option 2 seems to make sense in our case? And perhaps option 1 on top?

@zyzzyxdonta
Copy link
Contributor

Let me check if there is a switch I can flip so that this doesn't appear. I can't see how I'd have triggered this through review invitations.

@zyzzyxdonta Yea, this seems to have been triggered through the invitation of the group. These are the options for the team setup and code review:

grafik

At least option 2 seems to make sense in our case? And perhaps option 1 on top?

2 makes sense, yes. 1 not so much. If I assign the steering group I want all of them to see it, no matter if I "accidentally" select one of its members.

@sdruskat
Copy link
Contributor Author

2 makes sense, yes. 1 not so much. If I assign the steering group I want all of them to see it, no matter if I "accidentally" select one of its members.

Changed settings to look like this now. Look okay to you?

grafik

Copy link
Member

@led02 led02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question that needs to be discussed is, how to change these rules? Maybe all maintainers need to consent?

Other than that and the inline comments, I would have loved to see an issue for the website/ project part.

uses: fsfe/reuse-action@v5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: fsfe/reuse-action@v5
uses: fsfe/reuse-action@v5

Comment on lines +22 to +23
The maintainer and any member of the Steering Group can ask for a longer decision period,
which must be granted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this could lead to an infinite block by a block by a single member, maybe we should add a fallback here:

Suggested change
The maintainer and any member of the Steering Group can ask for a longer decision period,
which must be granted.
The maintainer and any member of the Steering Group can ask for a longer decision period,
which must be granted.
During this period, the steering committee should meet to discuss the decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Governance
4 participants