Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend CIM editing capabilities #27

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Extend CIM editing capabilities #27

wants to merge 5 commits into from

Conversation

martinmoraga
Copy link
Contributor

@martinmoraga martinmoraga commented Oct 26, 2023 •
edited by dinkelbachjan
Loading

This PR implementes new functions in cimedit.py (before was called utils.py) to add components to an existing cim topologie.

Based on #23 and #25

martinmoraga and others added 5 commits October 26, 2023 09:11
@martinmoraga
fix small error in cimexport.py
34c69e1 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
@martinmoraga
Update SynchronousMachineTimeConstantReactance.py
1d2357d 
initialize dynamic parameters of class SynchronousMachineTimeConstantReactance as float

Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
@martinmoraga
Update RotatingMachineDynamics.py
8a6ddc5 
initialize parameter 'inertia' of class RotatingMachineDynamics as float

Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
@Canfirat98 @martinmoraga
added new functions to utils.py
37bab23 
Signed-off-by: Canfirat98 <can.yaruk@rwth-aachen.de>
@Canfirat98 @martinmoraga
rename file utils.py
9c86e40 
Signed-off-by: Canfirat98 <can.yaruk@rwth-aachen.de>
@martinmoraga martinmoraga added the enhancement New feature or request label Oct 26, 2023
@martinmoraga martinmoraga self-assigned this Oct 26, 2023
@martinmoraga martinmoraga mentioned this pull request Oct 26, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 134 Code Smells

No Coverage information No Coverage information
18.8% 18.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dinkelbachjan dinkelbachjan self-requested a review October 26, 2023 11:38
@dinkelbachjan dinkelbachjan changed the title Ba can Exten CIM editing capabilities Oct 26, 2023
@dinkelbachjan dinkelbachjan changed the title Exten CIM editing capabilities Extend CIM editing capabilities Oct 26, 2023
@stv0g
Copy link
Contributor

stv0g commented Jun 20, 2024

Just wondering: Is there still some interest in getting this merged? Or can we close the PR?

@martinmoraga
Copy link
Contributor Author

martinmoraga commented Jun 21, 2024 •
edited
Loading

Just wondering: Is there still some interest in getting this merged? Or can we close the PR?

@stv0g These functionalities are needed for the dpsim CIM reader based on cimpy

@stv0g
Copy link
Contributor

stv0g commented Jun 21, 2024

Okay, I will rebase the changes to the current master.

Apart from the changes to the cgmes_v2_4_15 package it looks good to me.
The issue is that we should not directly modify those auto-generated files by hand.
We need to make those adjustments in the CIMgen repo.

But I can take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinkelbachjan dinkelbachjan Awaiting requested review from dinkelbachjan

At least 1 approving review is required to merge this pull request.

Assignees

@martinmoraga martinmoraga

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinmoraga @stv0g @Canfirat98