Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly move examples_test.go to examples package #70

Open
antongocode opened this issue Aug 27, 2019 · 1 comment
Open

Possibly move examples_test.go to examples package #70

antongocode opened this issue Aug 27, 2019 · 1 comment

Comments

@antongocode
Copy link

Apologies for this, but due to weirdness of go modules, see here golang/go#29323, when vendoring cmux as a dependency it also vendors google.golang.org/grpc purely because it is a test dependency.

Would you perhaps consider moving the example test to its own package?

@VoyTechnology
Copy link

This is still an issue, but this time with grpc/examples.

My editor complains about missing dependency:

google.golang.org/grpc/examples is not in your go.mod file

This is what happens when go mod tidy is ran:

go.mod

require (
    // ...
    github.com/soheilhy/cmux v0.1.4
    google.golang.org/grpc/examples v0.0.0-20210208035533-9280052d3665 // indirect
)
$ go mod why google.golang.org/grpc/examples/helloworld/helloworld
# google.golang.org/grpc/examples/helloworld/helloworld
<REDACTED PACKAGE NAME>
github.com/soheilhy/cmux
github.com/soheilhy/cmux.test
google.golang.org/grpc/examples/helloworld/helloworld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants