-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibly move examples_test.go to examples package #70
Comments
Merged
This is still an issue, but this time with My editor complains about missing dependency:
This is what happens when
$ go mod why google.golang.org/grpc/examples/helloworld/helloworld
# google.golang.org/grpc/examples/helloworld/helloworld
<REDACTED PACKAGE NAME>
github.com/soheilhy/cmux
github.com/soheilhy/cmux.test
google.golang.org/grpc/examples/helloworld/helloworld |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Apologies for this, but due to weirdness of go modules, see here golang/go#29323, when vendoring cmux as a dependency it also vendors google.golang.org/grpc purely because it is a test dependency.
Would you perhaps consider moving the example test to its own package?
The text was updated successfully, but these errors were encountered: