Adopt go modules #81
Merged
Adopt go modules #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this change. It's significant problem for etcd that, fact that we depend of cmux is adding wide set of additional undesired dependencies, |
|
@soheilhy Could you, please, comment on perspectives to have it merged (or in different way isolate transitive dependencies coming from the example) ? |
|
Happy to merge this. @rmfitzpatrick can you please rebase and resolve the conflict? |
|
@soheilhy, updated, thanks for your patience and review. |
|
/thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to satisfy #70 these changes adopt go modules and move the example content to a new
github.com/soheily/cmux/example* module.