Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change XxxRef class to interface for better testability. #55

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

ogaclejapan
Copy link
Contributor

@ogaclejapan ogaclejapan commented Aug 10, 2024

The implementation of XxxRef, which previously returned concrete classes directly from the Query and Mutation client interfaces, has been switched to returning them via an interface.

  • QueryRef
  • InfiniteQueryRef
  • MutationRef

This makes it easier to create mocks for previews and tests.

The implementation of XxxRef, which previously returned concrete classes directly from the Query and Mutation client
interfaces, has been switched to returning them via an interface.

This makes it easier to create mocks for previews and tests.
@ogaclejapan ogaclejapan added the breaking-change Breaking Changes label Aug 10, 2024
@ogaclejapan ogaclejapan merged commit 2b874a6 into main Aug 10, 2024
1 check passed
@ogaclejapan ogaclejapan deleted the query-ref-interface branch August 10, 2024 23:41
@github-actions github-actions bot mentioned this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaking Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant