Fix a NPE #57
Merged
Fix a NPE #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogaclejapan
added a commit
that referenced
this pull request
Aug 17, 2024
There was an issue in the Soil Query code where forced unwrapping was being used, which was addressed in PR #57 recently. In this PR, I have revisited the handling of nullable data types, identified as the root cause, and introduced a new `Reply<T>` type to eliminate the mismatch between `T?` and the type definition expected by users. Since the existing `data` property is likely referenced by users, the Reply model has been defined under a different property name to maintain backward compatibility. - data (unchanged) - dataUpdatedAt -> replyUpdatedAt (change) - reply (new) refs: #57
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error occurred when the return value of Query/Mutation nullable key(fetch/mutate) was Null.