Replace onPlaceholderData with onInitialData
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have renamed `onPlaceholderData` to `onInitialData` and shifted its role to that of an initial data set. We have decided to redesign the placeholder to be applied on a component basis in the future. In the TanStack Query, which we reference as a benchmark, it is designed to be used differently according to the application. - [Initial Query Data](https://tanstack.com/query/latest/docs/framework/react/guides/initial-query-data) - [Placeholder Query Data](https://tanstack.com/query/latest/docs/framework/react/guides/placeholder-query-data) The `onPlaceholderData` implemented in Soil Query did not align perfectly with either, having a position somewhat in between. From a usability perspective, it was deemed preferable to align the role more closely with Initial Query Data, and to prepare a new implementation for the placeholder.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have renamed
onPlaceholderDatatoonInitialDataand shifted its role to that of an initial data set. We have decided to redesign the placeholder to be applied on a component basis in the future.Background
In the TanStack Query, which we reference as a benchmark, it is designed to be used differently according to the application.
The
onPlaceholderDataimplemented in Soil Query did not align perfectly with either, having a position somewhat in between. From a usability perspective, it was deemed preferable to align the role more closely with Initial Query Data, and to prepare a new implementation for the placeholder.