Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrong terminationGracePeriodSeconds option in livenessProbe #12

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

L3o-pold
Copy link
Contributor

@L3o-pold L3o-pold commented Mar 4, 2022

error: error validating "bases/soketi/templates/deployment.yaml": error validating data: ValidationError(Deployment.spec.template.spec.containers[0].livenessProbe): unknown field "terminationGracePeriodSeconds" in io.k8s.api.core.v1.Probe; if you choose to ignore these errors, turn validation off with --validate=false

@rennokki rennokki merged commit a124b8e into soketi:master Mar 4, 2022
@rennokki
Copy link
Member

rennokki commented Mar 4, 2022

I misread this as issue and I disabled grace period from the probe by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants